Various fixes #1805
Various fixes #1805
Conversation
| PHP_VERSION: ${{matrix.php}} | ||
|
|
||
| - name: Composer Install | ||
| run: docker compose -f docker-compose.yml run -e PHP_VERSION=${{matrix.php}} test_runner composer install --no-progress |
There was a problem hiding this comment.
The php version variable isn't relevant at this point - we're never installing composer packages for old php versions.
|
|
||
| - name: Build Docker Container | ||
| run: docker compose -f docker-compose.yml build >/dev/null | ||
| run: docker compose -f docker-compose.yml build |
There was a problem hiding this comment.
I don't see why we would want to hide the build output - this could be very useful to debug build failures.
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Build Docker Container | ||
| run: docker compose -f docker-compose.yml build test_runner |
There was a problem hiding this comment.
Prebuilds the docker image, to avoid polluting the "composer install" step.
Side note: we could also move a couple of (build) steps to an earlier job that uploads the built image as an artifact and which both of the current jobs could depend on. But that's a story for another PR. :)
| #RUN echo "xdebug.output_dir=/opt/project/xdebug_snapshots" >> /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini | ||
| #RUN echo "xdebug.log=/opt/project/phpstorm-stubs/xdebug_logs/xdebug.log" >> /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini | ||
|
|
||
| RUN git config --global --add safe.directory /opt/project/phpstorm-stubs |
There was a problem hiding this comment.
This solves the annoying git warning about the directory being untrusted or suspicious.
|
Despite the many improvements, I still can't get the test results from the GH workflow (even from this PR) to much the local ones. None of the test suite tests count seems to match and worse still, I get a lot of errors and failures. Really wondering how's the situation with other contributors. |
1 participant
ReflectionData.jsontoReflectionData.datsince it does not contain valid json (I picked 'dat' since there isn't a well-defined format for PHP and 'dat' is generic enough)..gitignore'd (and removed).idea/since I couldn't see how this is helping anyone (and in fact made it worse by committing files by mistake).idey.README.mdto mentionrunTests.sh+ a slight formatting improvementrunTests.shreadability by adding a few blank linesrunTests.shsupport running against arbitrary PHP versions passed as parameters (instead of all versions)Relates to https://youtrack.jetbrains.com/issue/WI-82914/PHPStorm-stubs-project-state